JBolo C Code Notes

From WinBolo

These notes were made during the C->Java porting process on things that looked wrong in C code. Some of the them may have been fixed already...

Things to check in C code:

pillsDamage Pos
        wantangry flag ignored when it shouldn't be?
pillsBaseHit
        Should ignore in tank?
pillsDropNeutral
        log events in inner loop incorrect
pisllMigrate
        log events in inner loop incorrect

GetNumInRect
        should ignore tanks in tank?
WBN
        Add no event event
Shells
        Check add math vs java add math

playersleave game
        Do we want to skip own player number in alliance remove test?

playersSetLocation
        What is up with the found != 0xff section? Why not just do it inline?

-------------------------------------

bases
        change int type to short and make it network endianananan


network
        port in netjoinfinalise player num request
        data length of net map packet endianism

network
        add padding byte to fill out PLAYERNUM_REQ_PACKET
        Dont need to send extra byte in playerdata_req_packet
        dont need to send extra bytes back from server in playernum_response_packert
        Check CRC in getting player data
        endianism of short in retransmitted packet lengths!
        time packet need endians
        ping packet needs byte to align it!



PLAYERS
playersMakeNetAlliences - not called as is alliancesMakeReturn....x

treegrow
        No halfbuilding remove?
        treeGrowCalcScore - doing  && gw.getPills().existPos(mx, my) == false && gw.getBases().existPos(mx, my) == false twice (done in calling function)

starts
        If no bases place in dead middle of the map istead of undefined or 0,0
        In get start what the hell is up with if 0 then 1???

tankexp.c
        Need to network byte order worlds and fix floats...